Package Changes Through d5365e9

There are 6 changes which include barcode-scanner with minor, barcode-scanner-js with minor, window-state with minor, window-state-js with minor, fs with patch, fs-js with patch

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

Genuine question, does anyone know why it was designed to work like that or was that a mistake?

I see, it's from #295

not my proudest moment though it made sense to me at that time. i mean to some degree it still does. their requirements back then were valid imo so maybe we need 2 different functions.

but most of the api sucks a bit so maybe we should rethink the plugin from the ground up in v3

I'm thinking the more intuitive way of how it should work, is we reset the store to defaults first and then call extend to merge the values in load

@FabianLars @lucasfernog Any thoughts? Also should we change the behavior in v2 or wait for v3 for this? Asking because if the original intension was to making load work with defaults, this change will not break that usage, and unless someone actually uses the load to merge the on-disk values, we should be good

since the pr you linked was from before v2 imo we shouldn't change the behavior now. but idk both behaviors are flawed tbh

not my proudest moment though it made sense to me at that time. i mean to some degree it still does. their requirements back then were valid imo so maybe we need 2 different functions.

Yeah, that made sense to me as well, I didn't really thought about the defaults

since the pr you linked was from before v2 imo we shouldn't change the behavior now. but idk both behaviors are flawed tbh

Same thoughts now, let's wait for v3, also making 2 functions sounds good

I'm thinking 2 potential use cases

1. merging with default: when you add in for example a new config setting, the new setting's default will not be covered up by the old config file on user's computer
2. on the other hand, say you have a form or something, with some pre-filled default values, and in this case you want to load the exact file on disk, the defaults don't matter here